[WS CLI] Make env --scope=user compatible with GitLab groups
#20279
Conversation
|
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
github-actions
bot
added
the
meta: stale
filiptronicek
removed
the
meta: stale
There was a problem hiding this comment.
Code LGTM, tested both cases and they work flawlessly. ✔️
Awesome, thank you @filiptronicek ! 🙏
There was a problem hiding this comment.
Had to update these because they were flaky. When we create a workspace, we update its deletion eligibility time asynchronously and that created races in the tests. Now we call svc.updateDeletionEligibilityTime explicitly and synchronously, so that we get rid of that possible variance.
There was a problem hiding this comment.
I also base the test expectations off of the creationTime the instances are created with because otherwise we're comparing a date at the beginning of the test with a date at the end of it, which can cause trouble when we're at the edge of a millisecond. We could improve by not relying on the instance's creationTime and storing it ourselves separately, but this will do for now.
Description
Makes the "user scope" that the CLI lets you modify
*/**instead of the previous*/*.Related Issue(s)
Fixes ENT-847
How to test
*/**This should update the contents of your variable's value to
bar. You probably didn't name your variablefoo, so change that part if you want to see it work.Check the dashboard for the update or simply do
gp envFor backwards compat, also try having a differently-named environment variable with the old
*/*scope and try to update it withgp env --user. It should also work